Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make passed getEngagementLauncher queuesId paramater non-nullable #1092

Merged
merged 1 commit into from
Oct 25, 2024
Merged

Make passed getEngagementLauncher queuesId paramater non-nullable #1092

merged 1 commit into from
Oct 25, 2024

Conversation

ykyivskyi-gl
Copy link
Contributor

MOB-3738
What was solved?
This PR makes queuesId passed parameter of public method getEngagementLauncher non-nullable.

Release notes:

  • Feature
  • Ignore
  • Release notes (Is it clear from the description here?)
  • Migration guide (If changes are needed for integrator already using the SDK - what needs to be communicated? Add underneath please)

Additional info:

  • Is the feature sufficiently tested? All tests fixed? Necessary unit, acceptance, snapshots added? Check that at least new public classes & methods are covered with unit tests
  • Did you add logging beneficial for troubleshooting of customer issues?
  • Did you add new logging? We would like the logging between platforms to be similar. Refer to Logging from iOS SDKs → Things to consider for newly added logs in Confluence for more information.

Screenshots:

@ykyivskyi-gl
Copy link
Contributor Author

!squash

@sm-deployer sm-deployer force-pushed the MOB-3738-make-queuesid-non-nullable-get-EL branch from 50b053d to 9732917 Compare October 25, 2024 09:43
@ykyivskyi-gl ykyivskyi-gl merged commit 58bb1ab into feature/entry-widget-and-secure-conversations-v2 Oct 25, 2024
8 checks passed
@ykyivskyi-gl ykyivskyi-gl deleted the MOB-3738-make-queuesid-non-nullable-get-EL branch October 25, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rasmustautsglia rasmustautsglia rasmustautsglia approved these changes

@igorkravchenko igorkravchenko igorkravchenko approved these changes

@EgorovEI EgorovEI Awaiting requested review from EgorovEI

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ykyivskyi-gl @igorkravchenko @rasmustautsglia